mojira.dev
MC-238257

Block states are referenced inconsistently with regards to spacing throughout the game

The bug

States of blocks seem to be inconsistently referenced throughout multiple of the game's technical corners, either as a single word "blockstate" or with a space "block state". Consistency would be expected among these references - a space (or underscore where applicable) would be preferable.

How to reproduce

One example; I haven't exhaustively checked all potential instances of this.

  1. Type in and execute this incomplete command: /setblock ~ ~ ~ minecraft:air[

    1. Note how the error message given by the game references a missing "block state" property with a space

  2. Now extract the game's jar file using one's preferred method, then navigate to the assets/minecraft directory

    1. Notice how it has a subfolder named "blockstates" without a space

Expected behaviour

A consistent spacing would be used throughout the game, using a space in readable strings, or an underscore in technical strings. This could easily be made to be the case for the blockstates directory, for example, which could be renamed to block_states, analogously to the mob_effect textures folder or the entity_types tag folder. Alternatively, blockstates files could be relocated to states/block.

Actual behaviour

There is no such universal consistency.

Linked issues

Attachments

Comments 3

Folders use internal naming (which is without space, just like data and resource packs), strings use visual naming (with space, even for packs). I adressed the pack folders back in the day, but it was deemed a non-issue. This is definitely in the same boat.

I also don't really see how this is related to 188595, that one is talking about a string VS a string, this is talking about strings VS internal/technical names.

Internal naming. As long as the game is consistent within itself, there is no issue.

muzikbike

(Unassigned)

Unconfirmed

(Unassigned)

inconsistent, string

1.17.1, 21w39a, 1.18.2

Retrieved