mojira.dev

sjx

Assigned

No issues.

Reported

Comments

Still an issue in 1.13.

Code analysis

Please link to this comment in the description.

The following is based on the decompiled version of Minecraft 1.13.

In net.minecraft.client.gui.GuiListWorldSelectionEntry

public void drawEntry(int listWidth, int slotHeight, int mouseX, int mouseY, boolean isSelected, float partialTicks)
{
    int y = this.getY();
    int x = this.getX();
    // ...
    if (this.client.gameSettings.touchscreen || isSelected)
    {
        // ...
        int j = mouseX - x;
        int i = j < 32 ? 32 : 0;

        if (this.worldSummary.markVersionInList())
        {
            Gui.drawModalRectWithCustomSizedTexture(x, y, 32.0F, (float)i, 32, 32, 256.0F, 256.0F);
            // ...
        }
        else
        {
            Gui.drawModalRectWithCustomSizedTexture(x, y, 0.0F, (float)i, 32, 32, 256.0F, 256.0F);
        }
    }
    // ...
}
public void drawEntry(int listWidth, int slotHeight, int mouseX, int mouseY, boolean isSelected, float partialTicks)
{
    int y = this.getY();
    int x = this.getX();
    // ...
    if (this.client.gameSettings.touchscreen || isSelected)
    {
        // ...
        int j = mouseX - x;
        int i = j < 32 ? 32 : 0;

        if (this.worldSummary.markVersionInList())
        {
            Gui.drawModalRectWithCustomSizedTexture(x, y, 32.0F, (float)i, 32, 32, 256.0F, 256.0F);
            // ...
        }
        else
        {
            Gui.drawModalRectWithCustomSizedTexture(x, y, 0.0F, (float)i, 32, 32, 256.0F, 256.0F);
        }
    }
    // ...
}

It seems that whether the mouse is actually on the arrow is never checked.

Solution

In net.minecraft.client.gui.GuiListWorldSelectionEntry, net.minecraft.client.gui.ServerListEntryNormal and net.minecraft.client.resources.ResourcePackListEntryFound, check if the entry isSelected before rendering colored arrows.

@gaspoweredpick I cannot test right now. Try disabling the vanilla data pack and see if you can reproduce this.

Fixed in macOS 10.13.3 (17D47)

Confirmed for 17w43a-17w45b.

Try updating your computer's graphics driver

Confirmed in 16w06a.

I have these log in single player too:
{{{quote}
[11:31:35] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 2092ms behind, skipping 41 tick(s)
[11:31:57] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 8250ms behind, skipping 165 tick(s)
[11:32:12] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 6955ms behind, skipping 139 tick(s)
[11:32:27] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 4721ms behind, skipping 94 tick(s)
[11:34:25] [Server thread/WARN]: Can't keep up! Did the system time change, or is the server overloaded? Running 2233ms behind, skipping 44 tick(s)

}}

After exit the GUI press 'A' again without CMD