[MC-133200] Default advancement description color depends on frame, rather than being described in the JSON text-component

The bug

In this pre-release the descriptions of advancements have gotten colors based on their frame (challenge = dark_purple, frame and task = green). These colors should be described in the text-component of the advancement's description, rather than default to a certain color based on the frame.

The fix

Make the descriptions of advancements have a "color" key which sets the color, rather than the frame setting the default color.

Comments 8

Pau Olivares 2018-07-10T17:54:04Z

Confirmed in 1.13-pre7.

Kraif 2018-07-13T12:23:20Z

Confirmed for 1.13-pre8.

Kraif 2018-07-18T10:53:02Z

Confirmed for 1.13-pre10.

Kraif 2018-07-25T16:01:10Z

Confirmed for 18w30a.

user-f2760 2018-07-25T20:47:53Z

This is intentional, it can just be overwritten with the color component anyway.

This is not the only place using automatic colors either (item rarities, enchanted items).

AlexMCool 2018-07-25T21:32:19Z

@ FVbico, I’d rather see such a response from a Mojang employee. Might as well mark MC-124458 (a bug you reported) as WAI as well then...

user-f2760 2018-07-25T21:35:29Z

For that one it's the only place it's italic by default (inconsistent); and it's already tagged as "potentially WAI".
There was a bit of discussion about this report and the result was that this is WAI.

AlexMCool 2018-07-26T07:55:57Z

That’s unfortunate. I just really hate these kind of inconsistencies.