[MC-132938] Villagers don't accept datapack tags within "buy" recipes nbt

The bug

Villager's won't accept data tags within the "buy" nbt.

How to reproduce

Use a command such as this on a villager:

/data merge entity @e[type=minecraft:villager,limit=1,sort=nearest] {Offers:{Recipes: [{
    maxUses: 7, 
    buy: {id: "#minecraft:logs", Count: 1b}, 
    sell: {id: "minecraft:emerald", Count: 1b}, 
    uses: 0, 
    rewardExp: 1b
}]}

/data merge entity @e[type=minecraft:villager,limit=1,sort=nearest] {Offers:{Recipes: [{
    maxUses: 7, 
    buy: {id: "#minecraft:logs", Count: 1b}, 
    sell: {id: "minecraft:emerald", Count: 1b}, 
    uses: 0, 
    rewardExp: 1b
}]}

→ The villager should accept anything within the #minecraft:logs data tag, but denies any of them.

Comments 5

MukiTanuki 2018-07-06T22:39:18Z

I wasn't entirely sure if this was a bug, but I figured I'd put it here since other NBT tags can accept data tags within them, such as "CanPlaceOn" and "CanDestroy".

CreeperMagnet_ 2018-07-11T18:52:58Z

Can confirm.

CreeperMagnet_ 2018-07-12T23:09:51Z

This issue relates to MC-133374.

CreeperMagnet_ 2018-07-13T17:31:41Z

Affects 1.13-pre8.

tryashtar 2018-07-13T20:20:11Z

This is a good idea, but feature requests do not belong on the bug tracker.

Allow me to clarify the CanDestroy situation: the bug was that including # (or any non-[a-z0-9_./] character) would crash the game. After fixing that crash, additional support was added for this particular case.